Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make full identifier type default #594

Merged
merged 1 commit into from May 22, 2015
Merged

Conversation

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented May 18, 2015

No description provided.

@@ -23,7 +23,7 @@ def array_to_yaml(array)
# The syntax to use for patterns in the Rules file. Can be either `"glob"`
# (default) or `null`. The former will enable glob patterns, which behave like
Copy link
Member

@bobthecow bobthecow May 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ update the comment here?

Loading

Copy link
Member Author

@ddfreyne ddfreyne May 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Loading

@ddfreyne ddfreyne force-pushed the make-full-identifier-type-default branch from af7520a to bd7f752 May 19, 2015
@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented May 19, 2015

Rebased onto master, ready to review.

Loading

@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented May 20, 2015

Build fails because of some JRuby oddness. I restarted the build.

Loading

@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented May 21, 2015

Well, I am not sure there is much I can do about #fnmatch crashing with a Java ArrayIndexOutOfBoundsException (except report it).

Loading

@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented May 22, 2015

Can’t reproduce the issue locally. I marked JRuby 9000 as an allowed failure, because it failing doesn’t necessary imply a bug in nanoc.

Loading

ddfreyne added a commit that referenced this issue May 22, 2015
@ddfreyne ddfreyne merged commit 0a91fa4 into master May 22, 2015
1 check failed
Loading
@ddfreyne ddfreyne deleted the make-full-identifier-type-default branch May 22, 2015
@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented May 22, 2015

Post-merge +1s are OK :)

Loading

@ddfreyne ddfreyne added this to the 4.0.0 milestone Jun 20, 2015
@ddfreyne ddfreyne added this to the 4.0.0 milestone Jun 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants