Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make full identifier type default #594

Merged
merged 1 commit into from May 22, 2015

Conversation

Projects
None yet
2 participants
@ddfreyne
Copy link
Member

ddfreyne commented May 18, 2015

No description provided.

@@ -23,7 +23,7 @@ def array_to_yaml(array)
# The syntax to use for patterns in the Rules file. Can be either `"glob"`
# (default) or `null`. The former will enable glob patterns, which behave like

This comment has been minimized.

@bobthecow

bobthecow May 18, 2015

Member

^ update the comment here?

This comment has been minimized.

@ddfreyne

ddfreyne May 19, 2015

Author Member

Done

@ddfreyne ddfreyne force-pushed the make-full-identifier-type-default branch from af7520a to bd7f752 May 19, 2015

@ddfreyne

This comment has been minimized.

Copy link
Member Author

ddfreyne commented May 19, 2015

Rebased onto master, ready to review.

@ddfreyne

This comment has been minimized.

Copy link
Member Author

ddfreyne commented May 20, 2015

Build fails because of some JRuby oddness. I restarted the build.

@ddfreyne

This comment has been minimized.

Copy link
Member Author

ddfreyne commented May 21, 2015

Well, I am not sure there is much I can do about #fnmatch crashing with a Java ArrayIndexOutOfBoundsException (except report it).

@ddfreyne

This comment has been minimized.

Copy link
Member Author

ddfreyne commented May 22, 2015

Can’t reproduce the issue locally. I marked JRuby 9000 as an allowed failure, because it failing doesn’t necessary imply a bug in nanoc.

ddfreyne added a commit that referenced this pull request May 22, 2015

@ddfreyne ddfreyne merged commit 0a91fa4 into master May 22, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@ddfreyne ddfreyne deleted the make-full-identifier-type-default branch May 22, 2015

@ddfreyne

This comment has been minimized.

Copy link
Member Author

ddfreyne commented May 22, 2015

Post-merge +1s are OK :)

@ddfreyne ddfreyne modified the milestone: 4.0.0 Jun 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.