Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document class #618

Merged
merged 2 commits into from Jun 6, 2015
Merged

Document class #618

merged 2 commits into from Jun 6, 2015

Conversation

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Jun 6, 2015

  • Create Document supertype for Item and Layout. These two classes are quite similar (have content, attributes, and identifier), so making them of a similar type makes sense.
  • Create DocumentView supertype. This DRYs up the implementation of ItemView and LayoutView, and makes #fetch and #key? available in LayoutView.
@ddfreyne ddfreyne force-pushed the document-class branch from 915d152 to 5a937c9 Jun 6, 2015
@ddfreyne ddfreyne force-pushed the document-class branch from 5a937c9 to 716725b Jun 6, 2015
ddfreyne added a commit that referenced this issue Jun 6, 2015
@ddfreyne ddfreyne merged commit b6068e7 into master Jun 6, 2015
1 check was pending
Loading
@ddfreyne ddfreyne deleted the document-class branch Jun 6, 2015
@bobthecow
Copy link
Member

@bobthecow bobthecow commented Jun 6, 2015

👍

Loading

@ddfreyne ddfreyne added this to the 4.0.0 milestone Jun 20, 2015
@ddfreyne ddfreyne added this to the 4.0.0 milestone Jun 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants