New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document class #618

Merged
merged 2 commits into from Jun 6, 2015

Conversation

Projects
None yet
2 participants
@ddfreyne
Member

ddfreyne commented Jun 6, 2015

  • Create Document supertype for Item and Layout. These two classes are quite similar (have content, attributes, and identifier), so making them of a similar type makes sense.
  • Create DocumentView supertype. This DRYs up the implementation of ItemView and LayoutView, and makes #fetch and #key? available in LayoutView.

ddfreyne added some commits Jun 6, 2015

ddfreyne added a commit that referenced this pull request Jun 6, 2015

@ddfreyne ddfreyne merged commit b6068e7 into master Jun 6, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@ddfreyne ddfreyne deleted the document-class branch Jun 6, 2015

@bobthecow

This comment has been minimized.

Show comment
Hide comment
@bobthecow

bobthecow Jun 6, 2015

Member

👍

Member

bobthecow commented Jun 6, 2015

👍

@ddfreyne ddfreyne modified the milestone: 4.0.0 Jun 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment