Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create mutable document view #619

Merged
merged 1 commit into from Jun 6, 2015
Merged

Create mutable document view #619

merged 1 commit into from Jun 6, 2015

Conversation

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Jun 6, 2015

This DRYs up some view code.

It also makes #update_attributes available for layout views.

I’m not super happy with the use of mixins here, but it does the job and makes the code cleaner. I’ll probably revisit this at some point.

ddfreyne added a commit that referenced this issue Jun 6, 2015
@ddfreyne ddfreyne merged commit 0f7cfec into master Jun 6, 2015
1 check was pending
Loading
@ddfreyne ddfreyne deleted the document-mixins branch Jun 6, 2015
@ddfreyne ddfreyne added this to the 4.0.0 milestone Jun 20, 2015
@ddfreyne ddfreyne added this to the 4.0.0 milestone Jun 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant