New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix show rules #633

Merged
merged 1 commit into from Jun 14, 2015

Conversation

Projects
None yet
2 participants
@ddfreyne
Member

ddfreyne commented Jun 12, 2015

Checksumming is used to determine whether rules have changed, and thus it is no longer possible to show the full rules.

What is possible, however, is show which items match against which rules. This PR modifies the command to work that way.

Example output:

Item /docs/troubleshooting.md:
  Rep default: /**/*

Item /docs/tutorial.md:
  Rep default: /**/*

Item /favicon.ico:
  Rep default: /favicon.ico

Item /index.html:
  Rep default: /index.*

Item /release-notes:
  Rep default: /**/*

Item /robots.txt.erb:
  Rep default: /robots.*

Item /sitemap.xml.erb:
  Rep default: /sitemap.*

Item /style-guide.md:
  Rep default: /**/*

Layout /autodoc_partial.erb:
  /**/*

Layout /default.html.erb:
  /**/*
Fix and simplify show-rules command
Checksumming is used to determine whether rules have changed, and thus
it is no longer possible to show the full rules.

ddfreyne added a commit that referenced this pull request Jun 14, 2015

@ddfreyne ddfreyne merged commit 21a1522 into master Jun 14, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@ddfreyne ddfreyne deleted the fix-show-rules branch Jun 14, 2015

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Jun 14, 2015

Member

The show-rules command spec isn’t the prettiest, but at least the command is now tested (it wasn’t before).

Member

ddfreyne commented Jun 14, 2015

The show-rules command spec isn’t the prettiest, but at least the command is now tested (it wasn’t before).

@bobthecow

This comment has been minimized.

Show comment
Hide comment
@bobthecow

bobthecow Jun 14, 2015

Member

👍

Member

bobthecow commented Jun 14, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment