New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added `.atom` to default text extensions #657

Merged
merged 1 commit into from Jun 27, 2015

Conversation

Projects
None yet
3 participants
@ihmels
Contributor

ihmels commented Jun 25, 2015

No description provided.

@gpakosz

This comment has been minimized.

Show comment
Hide comment
@gpakosz

gpakosz Jun 25, 2015

Member

What is this file extension suppose to refer to?

Member

gpakosz commented Jun 25, 2015

What is this file extension suppose to refer to?

@ihmels

This comment has been minimized.

Show comment
Hide comment
@ihmels

ihmels Jun 25, 2015

Contributor

It refers to atom feeds (MIME type is application/atom+xml).

Contributor

ihmels commented Jun 25, 2015

It refers to atom feeds (MIME type is application/atom+xml).

@gpakosz

This comment has been minimized.

Show comment
Hide comment
@gpakosz

gpakosz Jun 25, 2015

Member

And you have Atom feeds stored in .atom files inside your content/ directory?

Member

gpakosz commented Jun 25, 2015

And you have Atom feeds stored in .atom files inside your content/ directory?

@ihmels

This comment has been minimized.

Show comment
Hide comment
@ihmels

ihmels Jun 25, 2015

Contributor

Yes, because it’s the extension for atom feed files. Using .atom as extension allows me to set the proper MIME type in .htaccess file.

Contributor

ihmels commented Jun 25, 2015

Yes, because it’s the extension for atom feed files. Using .atom as extension allows me to set the proper MIME type in .htaccess file.

@gpakosz

This comment has been minimized.

Show comment
Hide comment
@gpakosz

gpakosz Jun 25, 2015

Member

Hmm yes but, likely Nanoc generates e.g. output/feed.atom from e.g. content/feed.erb. In content/feed.erb you typically list items and format them into an Atom feed that gets routed to output/feed.atom.

In that respect, there's no reason to change the content of the text_extensions array.

Member

gpakosz commented Jun 25, 2015

Hmm yes but, likely Nanoc generates e.g. output/feed.atom from e.g. content/feed.erb. In content/feed.erb you typically list items and format them into an Atom feed that gets routed to output/feed.atom.

In that respect, there's no reason to change the content of the text_extensions array.

@ihmels

This comment has been minimized.

Show comment
Hide comment
@ihmels

ihmels Jun 25, 2015

Contributor

Then why there is html, htm or xhtml in the text_extensions array? Nanoc would route content/hello-world.erb to output/hello-world.html if you instruct it in the Rules file.

Contributor

ihmels commented Jun 25, 2015

Then why there is html, htm or xhtml in the text_extensions array? Nanoc would route content/hello-world.erb to output/hello-world.html if you instruct it in the Rules file.

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Jun 27, 2015

Member

👍

Member

ddfreyne commented Jun 27, 2015

👍

ddfreyne added a commit that referenced this pull request Jun 27, 2015

Merge pull request #657 from yannickihmels/master
Added `.atom` to default text extensions

@ddfreyne ddfreyne merged commit 29064f0 into nanoc:master Jun 27, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 98.04%
Details

@ddfreyne ddfreyne added this to the 4.1.0 milestone Jun 27, 2015

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Jun 27, 2015

Member

FYI, this will land in nanoc 4.1, since nanoc 4.0 is feature-frozen.

Member

ddfreyne commented Jun 27, 2015

FYI, this will land in nanoc 4.1, since nanoc 4.0 is feature-frozen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment