Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .atom to default text extensions #657

Merged
merged 1 commit into from Jun 27, 2015
Merged

Added .atom to default text extensions #657

merged 1 commit into from Jun 27, 2015

Conversation

@ihmels
Copy link
Contributor

@ihmels ihmels commented Jun 25, 2015

No description provided.

@gpakosz
Copy link
Member

@gpakosz gpakosz commented Jun 25, 2015

What is this file extension suppose to refer to?

Loading

@ihmels
Copy link
Contributor Author

@ihmels ihmels commented Jun 25, 2015

It refers to atom feeds (MIME type is application/atom+xml).

Loading

@gpakosz
Copy link
Member

@gpakosz gpakosz commented Jun 25, 2015

And you have Atom feeds stored in .atom files inside your content/ directory?

Loading

@ihmels
Copy link
Contributor Author

@ihmels ihmels commented Jun 25, 2015

Yes, because it’s the extension for atom feed files. Using .atom as extension allows me to set the proper MIME type in .htaccess file.

Loading

@gpakosz
Copy link
Member

@gpakosz gpakosz commented Jun 25, 2015

Hmm yes but, likely Nanoc generates e.g. output/feed.atom from e.g. content/feed.erb. In content/feed.erb you typically list items and format them into an Atom feed that gets routed to output/feed.atom.

In that respect, there's no reason to change the content of the text_extensions array.

Loading

@ihmels
Copy link
Contributor Author

@ihmels ihmels commented Jun 25, 2015

Then why there is html, htm or xhtml in the text_extensions array? Nanoc would route content/hello-world.erb to output/hello-world.html if you instruct it in the Rules file.

Loading

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Jun 27, 2015

👍

Loading

ddfreyne added a commit that referenced this issue Jun 27, 2015
Added `.atom` to default text extensions
@ddfreyne ddfreyne merged commit 29064f0 into nanoc:master Jun 27, 2015
2 checks passed
Loading
@ddfreyne ddfreyne added this to the 4.1.0 milestone Jun 27, 2015
@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Jun 27, 2015

FYI, this will land in nanoc 4.1, since nanoc 4.0 is feature-frozen.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants