New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make base_url optional in #tags_for #687

Merged
merged 3 commits into from Aug 8, 2015

Conversation

Projects
None yet
2 participants
@croath
Contributor

croath commented Aug 4, 2015

While using version 4.0.2rc2, one error occurred after Tagging helper and tags_for method were added into my code, which told me a KeyError around key base_url.

I checked the source in release-4.0.x and found that base_url must be provided or there will be an error here. It's never been listed in the document or the official tutorial.

In my mind it's not so important that users MUST have a link to a tag, at least there should be a default tag link url.

Thank you so much for your review.

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Aug 4, 2015

Member

I think it would make more sense to let base_url be optional, and not generate a link if a base_url is not provided.

Member

ddfreyne commented Aug 4, 2015

I think it would make more sense to let base_url be optional, and not generate a link if a base_url is not provided.

@croath

This comment has been minimized.

Show comment
Hide comment
@croath

croath Aug 5, 2015

Contributor

@ddfreyne Yes you are right... I mean, it really make sense. Check the appending commit 😄

Contributor

croath commented Aug 5, 2015

@ddfreyne Yes you are right... I mean, it really make sense. Check the appending commit 😄

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Aug 5, 2015

Member

This looks good! Could you make sure to update the tests too?

Member

ddfreyne commented Aug 5, 2015

This looks good! Could you make sure to update the tests too?

@croath

This comment has been minimized.

Show comment
Hide comment
@croath

croath Aug 6, 2015

Contributor

Test function added!

Contributor

croath commented Aug 6, 2015

Test function added!

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Aug 8, 2015

Member

Looks good. Thanks!

Member

ddfreyne commented Aug 8, 2015

Looks good. Thanks!

ddfreyne added a commit that referenced this pull request Aug 8, 2015

Merge pull request #687 from croath/release-4.0.x
Make base_url optional in #tags_for

@ddfreyne ddfreyne merged commit 72429ce into nanoc:release-4.0.x Aug 8, 2015

@croath

This comment has been minimized.

Show comment
Hide comment
@croath

croath Aug 9, 2015

Contributor

With pleasure 😄

Contributor

croath commented Aug 9, 2015

With pleasure 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment