New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identifier with multiple exts #696

Merged
merged 2 commits into from Aug 17, 2015

Conversation

Projects
None yet
2 participants
@barraq
Contributor

barraq commented Aug 17, 2015

This PR extends Nanoc::Identifier with two new methods to handle identifiers with multiple exts. Two methods are added:

  • #exts which returns a list of extensions of an identifier
  • #without_exts which removes all extensions of an identifier

This PR is related to #679

@barraq barraq referenced this pull request Aug 17, 2015

Closed

addresses #664 #679

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Aug 17, 2015

Member

Looks good, thanks!

Member

ddfreyne commented Aug 17, 2015

Looks good, thanks!

ddfreyne added a commit that referenced this pull request Aug 17, 2015

@ddfreyne ddfreyne merged commit ad4f279 into nanoc:release-4.0.x Aug 17, 2015

@ddfreyne ddfreyne referenced this pull request Aug 17, 2015

Closed

#with_ext is confusing #697

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Aug 17, 2015

Member

I created a separate ticket to track ideas around the #with_ext confusion here: #697. Open to suggestions; nothing’s been decided yet.

Member

ddfreyne commented Aug 17, 2015

I created a separate ticket to track ideas around the #with_ext confusion here: #697. Open to suggestions; nothing’s been decided yet.

@barraq

This comment has been minimized.

Show comment
Hide comment
@barraq

barraq Aug 17, 2015

Contributor

👍

Contributor

barraq commented Aug 17, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment