Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only attempt to clean if the item is a string #712

Merged
merged 1 commit into from Oct 28, 2015

Conversation

Projects
None yet
2 participants
@gjtorikian
Copy link
Member

commented Oct 22, 2015

I've noticed that if I try to do some quick debugging—like, puts @config, this little helper will complain about a missing gsub, because s is a Hash or a String or something.

I think it's necessary every now and then to not assume everything being printed is a string, so this PR protects against that.

@ddfreyne ddfreyne added this to the 4.1.0 milestone Oct 28, 2015

@ddfreyne

This comment has been minimized.

Copy link
Member

commented Oct 28, 2015

Makes sense, thanks!

ddfreyne added a commit that referenced this pull request Oct 28, 2015

Merge pull request #712 from nanoc/keep-cool-ansi
Only attempt to clean if the item is a string

@ddfreyne ddfreyne merged commit 8910ab7 into master Oct 28, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 98.052%
Details

@ddfreyne ddfreyne deleted the keep-cool-ansi branch Oct 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.