Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed english text from link_to helper. #736

Merged
merged 3 commits into from Nov 28, 2015
Merged

Removed english text from link_to helper. #736

merged 3 commits into from Nov 28, 2015

Conversation

@lvuotto
Copy link
Contributor

@lvuotto lvuotto commented Nov 27, 2015

The link_to_unless_current function from link_to helper was outputing english text. This should be avoided.

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Nov 28, 2015

Makes sense! Could you fix the failing tests please?

Loading

@ddfreyne ddfreyne added this to the 4.0.1 milestone Nov 28, 2015
@ddfreyne ddfreyne added this to the 4.1.0 milestone Nov 28, 2015
@ddfreyne ddfreyne removed this from the 4.0.1 milestone Nov 28, 2015
ddfreyne added a commit that referenced this issue Nov 28, 2015
Removed english text from link_to helper.
@ddfreyne ddfreyne merged commit 417f462 into nanoc:master Nov 28, 2015
1 of 2 checks passed
Loading
@rosetree
Copy link
Contributor

@rosetree rosetree commented Dec 11, 2015

Thanks @lvuotto!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants