Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed english text from link_to helper. #736

merged 3 commits into from Nov 28, 2015


None yet
3 participants
Copy link

commented Nov 27, 2015

The link_to_unless_current function from link_to helper was outputing english text. This should be avoided.


This comment has been minimized.

Copy link

commented Nov 28, 2015

Makes sense! Could you fix the failing tests please?

@ddfreyne ddfreyne modified the milestones: 4.0.1, 4.1.0 Nov 28, 2015

ddfreyne added a commit that referenced this pull request Nov 28, 2015

Merge pull request #736 from lvuotto/master
Removed english text from link_to helper.

@ddfreyne ddfreyne merged commit 417f462 into nanoc:master Nov 28, 2015

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.005%) to 91.594%
continuous-integration/travis-ci/pr The Travis CI build passed

This comment has been minimized.

Copy link

commented Dec 11, 2015

Thanks @lvuotto!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.