New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparisons #738

Merged
merged 1 commit into from Nov 28, 2015

Conversation

Projects
None yet
1 participant
@ddfreyne
Member

ddfreyne commented Nov 28, 2015

  • Made comparing identifiers somewhat more strict (don’t blindly call #to_s)
  • Make Document equality less strict (don’t require the exact same class—a view also works)
  • Don’t crash when comparing an ItemRepView with something else (fixes #735).

@ddfreyne ddfreyne added the to review label Nov 28, 2015

@ddfreyne ddfreyne added this to the 4.0.1 milestone Nov 28, 2015

ddfreyne added a commit that referenced this pull request Nov 28, 2015

@ddfreyne ddfreyne merged commit fa59c47 into release-4.0.x Nov 28, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.006%) to 91.443%
Details

@ddfreyne ddfreyne deleted the fix-comparisons branch Nov 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment