Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load commands as UTF-8 #742

Merged
merged 1 commit into from Nov 28, 2015
Merged

Load commands as UTF-8 #742

merged 1 commit into from Nov 28, 2015

Conversation

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Nov 28, 2015

Fixes #741.

Nanoc loads commands using the environment’s encoding. We know for a fact that these are UTF-8, so relying on the environment is unnecessary, and even wrong, as shown by the crash.

@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Nov 28, 2015

CC @nrdufour — this fixes your issue.

Loading

ddfreyne added a commit that referenced this issue Nov 28, 2015
@ddfreyne ddfreyne merged commit e6473e9 into release-4.0.x Nov 28, 2015
2 checks passed
Loading
@ddfreyne ddfreyne deleted the load-commands-as-utf-8 branch Nov 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant