New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load commands as UTF-8 #742

Merged
merged 1 commit into from Nov 28, 2015

Conversation

Projects
None yet
1 participant
@ddfreyne
Member

ddfreyne commented Nov 28, 2015

Fixes #741.

Nanoc loads commands using the environment’s encoding. We know for a fact that these are UTF-8, so relying on the environment is unnecessary, and even wrong, as shown by the crash.

@ddfreyne ddfreyne added this to the 4.0.2 milestone Nov 28, 2015

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Nov 28, 2015

Member

CC @nrdufour — this fixes your issue.

Member

ddfreyne commented Nov 28, 2015

CC @nrdufour — this fixes your issue.

ddfreyne added a commit that referenced this pull request Nov 28, 2015

@ddfreyne ddfreyne merged commit e6473e9 into release-4.0.x Nov 28, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 91.447%
Details

@ddfreyne ddfreyne deleted the load-commands-as-utf-8 branch Nov 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment