New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix final :pre snapshot not being generated #764

Merged
merged 1 commit into from Dec 11, 2015

Conversation

Projects
None yet
2 participants
@ddfreyne
Member

ddfreyne commented Dec 10, 2015

The :pre snapshot is not generated properly (it remains “non-final”). This PR fixes that.

The NonFinalSnapshotWithPathError error might need to be removed. I’ll try to keep it in (it’s useful) but getting it to work properly might be hard.

Fixes #762.

@ddfreyne ddfreyne added this to the 4.1.0 milestone Dec 10, 2015

@ddfreyne ddfreyne added to review and removed status:wip 🔧 labels Dec 11, 2015

ddfreyne added a commit that referenced this pull request Dec 11, 2015

Merge pull request #764 from nanoc/fix-pre-snapshot
Fix final :pre snapshot not being generated

@ddfreyne ddfreyne merged commit 4742740 into master Dec 11, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the fix-pre-snapshot branch Dec 11, 2015

@gjtorikian

This comment has been minimized.

Show comment
Hide comment
@gjtorikian

gjtorikian Dec 11, 2015

Member

Unfortunately, while using compiled_content, this still yields an error. Not sure if you wanted that fixed or not based on

(It might be the case that Nanoc 4.1.0a1’s behavior is in fact more correct.)

Member

gjtorikian commented Dec 11, 2015

Unfortunately, while using compiled_content, this still yields an error. Not sure if you wanted that fixed or not based on

(It might be the case that Nanoc 4.1.0a1’s behavior is in fact more correct.)

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Dec 12, 2015

Member

Ack—I guess that’s why it’s still in beta :).

Lesson learnt for me: when fixing a bug, try the original test case again to make sure the right bug is tackled.

I’ll reopen the original issue and look into it again.

Member

ddfreyne commented Dec 12, 2015

Ack—I guess that’s why it’s still in beta :).

Lesson learnt for me: when fixing a bug, try the original test case again to make sure the right bug is tackled.

I’ll reopen the original issue and look into it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment