New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using #compiled_content in layout #766

Merged
merged 1 commit into from Dec 12, 2015

Conversation

Projects
None yet
2 participants
@ddfreyne
Member

ddfreyne commented Dec 12, 2015

Using @item.compiled_content in a layout broke in 4.1.0a1. This was caused by #compiled_content searching for the first snapshot with a given name (in this case, :pre) rather than the last one.

I’ve created a separate regression test in spec/nanoc/regressions. I haven’t done something like this before, but it seems sensible.

Fixes #761.

@ddfreyne ddfreyne added this to the 4.1.0 milestone Dec 12, 2015

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Dec 12, 2015

Member

@gjtorikian This is the proper fix.

Member

ddfreyne commented Dec 12, 2015

@gjtorikian This is the proper fix.

@ddfreyne ddfreyne added the to review label Dec 12, 2015

ddfreyne added a commit that referenced this pull request Dec 12, 2015

@ddfreyne ddfreyne merged commit 628847c into master Dec 12, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the allow-compiled-content-in-layout branch Dec 12, 2015

@gjtorikian

This comment has been minimized.

Show comment
Hide comment
@gjtorikian

gjtorikian Dec 12, 2015

Member

Confirmed fixed in 4.1.0rc1. Thanks!

Member

gjtorikian commented Dec 12, 2015

Confirmed fixed in 4.1.0rc1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment