Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove env from crash.log #800

Merged
merged 1 commit into from Jan 13, 2016
Merged

Remove env from crash.log #800

merged 1 commit into from Jan 13, 2016

Conversation

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Jan 13, 2016

The environment can contain sensitive information, and so it shouldn’t be included in crash.log by default.

CC @gjtorikian

See #798.

@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Jan 13, 2016

The error handler is lacking in detailed tests, hence no change in specs/tests.

Loading

@gjtorikian
Copy link
Member

@gjtorikian gjtorikian commented Jan 13, 2016

❤️

Loading

ddfreyne added a commit that referenced this issue Jan 13, 2016
@ddfreyne ddfreyne merged commit 9787070 into release-4.1.x Jan 13, 2016
1 check passed
Loading
@ddfreyne ddfreyne deleted the remove-env-from-crash-log-2 branch Jan 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants