New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove env from crash.log #800

Merged
merged 1 commit into from Jan 13, 2016

Conversation

Projects
None yet
2 participants
@ddfreyne
Member

ddfreyne commented Jan 13, 2016

The environment can contain sensitive information, and so it shouldn’t be included in crash.log by default.

CC @gjtorikian

See #798.

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Jan 13, 2016

Member

The error handler is lacking in detailed tests, hence no change in specs/tests.

Member

ddfreyne commented Jan 13, 2016

The error handler is lacking in detailed tests, hence no change in specs/tests.

@gjtorikian

This comment has been minimized.

Show comment
Hide comment
@gjtorikian

gjtorikian Jan 13, 2016

Member

❤️

Member

gjtorikian commented Jan 13, 2016

❤️

ddfreyne added a commit that referenced this pull request Jan 13, 2016

@ddfreyne ddfreyne merged commit 9787070 into release-4.1.x Jan 13, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the remove-env-from-crash-log-2 branch Jan 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment