Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix show-data crash #835

Merged
merged 1 commit into from Mar 8, 2016
Merged

Fix show-data crash #835

merged 1 commit into from Mar 8, 2016

Conversation

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Mar 5, 2016

Fixes #833.

This PR has a fix and a regression test, but I’d like to take the time to write a proper spec for the show-data command. That command has been around for a while and has always “just worked”—until now, apparently, and I’d like to ensure that it keeps on working.

@ddfreyne ddfreyne added this to the 4.1.5 milestone Mar 5, 2016
@ddfreyne ddfreyne mentioned this pull request Mar 5, 2016
@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Mar 8, 2016

I’m OK with only having a regression test for now.

The CLI commands have generally rather bad code coverage (and the way they’re loaded makes it impossible for the code coverage tool to detect them), so I’d like to tackle that in a separate PR.

Loading

ddfreyne added a commit that referenced this issue Mar 8, 2016
@ddfreyne ddfreyne merged commit 323883c into release-4.1.x Mar 8, 2016
1 check passed
Loading
@ddfreyne ddfreyne deleted the gh-833-fix-show-data-crash-2 branch Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant