New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WeakRef::RefError #865

Merged
merged 1 commit into from Jun 9, 2016

Conversation

Projects
None yet
1 participant
@ddfreyne
Member

ddfreyne commented Jun 8, 2016

I assume that checking #weakref_alive? is not a strong guarantee that the ref is alive. Perhaps the ref dies after the call, but before it’s accessed?

Needs more rigorous (load) testing.

Fixes #863.

@ddfreyne ddfreyne added this to the 4.2.1 milestone Jun 8, 2016

@ddfreyne ddfreyne merged commit e12093d into release-4.2.x Jun 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Jun 9, 2016

Member

Load testing shows that this is fine.

Member

ddfreyne commented Jun 9, 2016

Load testing shows that this is fine.

@ddfreyne ddfreyne deleted the fix-weakref-error branch Jun 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment