New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune before compiling (fixes #942) #946

Merged
merged 1 commit into from Sep 26, 2016

Conversation

Projects
None yet
2 participants
@ddfreyne
Member

ddfreyne commented Sep 26, 2016

Prune before compiling, to delete any files/directories that could interfere with new files/directories being generated. Fixes #942.

@ddfreyne ddfreyne added this to the 4.3.3 milestone Sep 26, 2016

@ddfreyne ddfreyne merged commit 04fb046 into release-4.3.x Sep 26, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the prune-before-compile branch Sep 26, 2016

@agross

This comment has been minimized.

Show comment
Hide comment
@agross

agross Oct 1, 2016

Contributor

Unfortunately, this fails if site.config[:output_dir] does not exist at the time the pruner runs.

(My output directory is build/bin/web/bin)

>> Find.find('foo/bar/baz/') do |f| puts f; end
Errno::ENOENT: No such file or directory
        from C:/Ruby/lib/ruby/2.3.0/find.rb:43:in `block in find'
        from C:/Ruby/lib/ruby/2.3.0/find.rb:43:in `collect!'
        from C:/Ruby/lib/ruby/2.3.0/find.rb:43:in `find'

>> Find.find('foo/') do |f| puts f; end
Errno::ENOENT: No such file or directory
        from C:/Ruby/lib/ruby/2.3.0/find.rb:43:in `block in find'
        from C:/Ruby/lib/ruby/2.3.0/find.rb:43:in `collect!'
        from C:/Ruby/lib/ruby/2.3.0/find.rb:43:in `find'
        from (irb):11
        from C:/Ruby/bin/irb:11:in `<main>'
Contributor

agross commented Oct 1, 2016

Unfortunately, this fails if site.config[:output_dir] does not exist at the time the pruner runs.

(My output directory is build/bin/web/bin)

>> Find.find('foo/bar/baz/') do |f| puts f; end
Errno::ENOENT: No such file or directory
        from C:/Ruby/lib/ruby/2.3.0/find.rb:43:in `block in find'
        from C:/Ruby/lib/ruby/2.3.0/find.rb:43:in `collect!'
        from C:/Ruby/lib/ruby/2.3.0/find.rb:43:in `find'

>> Find.find('foo/') do |f| puts f; end
Errno::ENOENT: No such file or directory
        from C:/Ruby/lib/ruby/2.3.0/find.rb:43:in `block in find'
        from C:/Ruby/lib/ruby/2.3.0/find.rb:43:in `collect!'
        from C:/Ruby/lib/ruby/2.3.0/find.rb:43:in `find'
        from (irb):11
        from C:/Ruby/bin/irb:11:in `<main>'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment