Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'form/@action' to relativize paths filter #950

Closed

Conversation

@werthen
Copy link
Contributor

@werthen werthen commented Oct 4, 2016

Summary

Make action in form tags work with relativize_paths

barraq and others added 30 commits Aug 21, 2016
Introduce basic support for nanoc environment:
- nanoc command is updated to include --env argument
- config are overriden using the active environment if any
- unless define in environment, output_dir is {{output_dir}}/{{env_name}}

Setting environments is done in nanoc.yaml using the `environments` property.
Example usage is:

```
output_dir: output

environments:
  default: &default
    base_url: ...
    ...
  development:
    <<: *default
    base_url: ...
  production:
    <<: *default
    base_url: ...
  yet_another_env:
    <<: *default
    base_url: ...
    output_dir: build
```

Selecting working environment can be done:
- using environment variable `NANOC_ENVIRONMENT`
- using `nanoc --env=[<value>]`
- Document env attr_reader
- Only allow String and nil for environment name
- Remove argument for with_environment
- Make :environments a constant
- Lot of parentheses fix
- Renamed NANOC_ENVIRONMENT to NANOC_ENV for consistency with Rails, Rake, etc.
- Prefer Fetch(a,b) over a||b
- Refactor tmp_path logic into Nanoc::Int::Store
- Make -e, --env argument required
- Updated test according to previous changes
- add Contracts
- rename store to store_name
- use named arguments
@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Oct 7, 2016

Can you change the base branch of this PR to be release-4.3.x please? This way, this change will end up in the next patch release.

Loading

@ddfreyne ddfreyne added this to the 4.3.4 milestone Oct 7, 2016
Copy link
Member

@ddfreyne ddfreyne left a comment

Looks great!

Loading

@werthen werthen changed the base branch from master to release-4.3.x Oct 7, 2016
@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Oct 9, 2016

Looks like something went wrong with changing the base branch (presumably, the commits were made on master rather than on release-4.3.x).

I’ve cherry-picked the commit and it’s now on release-4.3.x!

Loading

@ddfreyne ddfreyne closed this Oct 9, 2016
@werthen
Copy link
Contributor Author

@werthen werthen commented Oct 9, 2016

My bad, I didn't have time to properly do this with git, so I just set the base branch in github to 4.3.x, but it seems github isn't so great at using git 😉

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants