New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only compile outdated reps #968

Merged
merged 3 commits into from Oct 28, 2016

Conversation

Projects
None yet
3 participants
@ddfreyne
Member

ddfreyne commented Oct 28, 2016

This revisits #894.

Detailed description

It’s possible for the compiler to only recompile outdated reps, as long as the compiled content in the preprocessor can still be accessed. This is why PostCompileItemRepView is introduced.

Related issues

(Add issue IDs for related issues here.)

ddfreyne added some commits Oct 28, 2016

Introduce PostCompileItemRepView
This view class will enable Nanoc to later get the compiled content in a
different way in the postprocess block (e.g. by reading it from the
cache rather than requiring the rep to have been compiled).

@ddfreyne ddfreyne merged commit e148ecc into master Oct 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the post-compile-cached-content branch Oct 28, 2016

@Fjan

This comment has been minimized.

Show comment
Hide comment
@Fjan

Fjan Nov 1, 2016

Contributor

👍 Awesome! Our site compilation just became much faster with 4.3.7

Contributor

Fjan commented Nov 1, 2016

👍 Awesome! Our site compilation just became much faster with 4.3.7

@jvoisin

This comment has been minimized.

Show comment
Hide comment
@jvoisin

jvoisin Nov 3, 2016

@Fjan Care to share some numbers?

jvoisin commented Nov 3, 2016

@Fjan Care to share some numbers?

@Fjan

This comment has been minimized.

Show comment
Hide comment
@Fjan

Fjan Nov 3, 2016

Contributor

@jvoisin on my Mac Pro it went from 6.34s to 3.47s so a 45% speedup. It's nice to get 3 seconds back for me, but we have a bunch of users on old laptops and those take about three times longer to compile, so things like live-reload were almost not usable for them before and are OK now.

Contributor

Fjan commented Nov 3, 2016

@jvoisin on my Mac Pro it went from 6.34s to 3.47s so a 45% speedup. It's nice to get 3 seconds back for me, but we have a bunch of users on old laptops and those take about three times longer to compile, so things like live-reload were almost not usable for them before and are OK now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment