From 142996cdbea4ef015a8b7255aaae5b18511dd288 Mon Sep 17 00:00:00 2001 From: Guilherme Lawless Date: Thu, 26 Mar 2020 17:48:51 +0000 Subject: [PATCH] Fix intermittent failure in active_transactions.confirmation_consistency (#2682) * Fix intermittent failure in active_transactions.confirmation_consistency `recently_cemented` is only changed in the conf height observer callbacks. This is the intended behavior, but the test was intermittently failing under TSAN. * Empty commit --- nano/core_test/active_transactions.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nano/core_test/active_transactions.cpp b/nano/core_test/active_transactions.cpp index 868f832a73..c477cadafa 100644 --- a/nano/core_test/active_transactions.cpp +++ b/nano/core_test/active_transactions.cpp @@ -851,7 +851,7 @@ TEST (active_transactions, confirmation_consistency) nano::lock_guard guard (node.active.mutex); ASSERT_EQ (i + 1, node.active.recently_confirmed.size ()); ASSERT_EQ (block->qualified_root (), node.active.recently_confirmed.back ().first); - ASSERT_EQ (i + 1, node.active.recently_cemented.size ()); + ASSERT_TIMELY (1s, i + 1 == node.active.recently_cemented.size ()); // done after a callback } } }