Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy way to switch between beta/live network #1099

Closed
Inkeliz opened this issue Aug 24, 2018 · 6 comments

Comments

4 participants
@Inkeliz
Copy link

commented Aug 24, 2018

In Bitcoin allow the user to switch between live/testnet change the configuration of bitcoin.conf, setting testnet=1. It's easier and simple. This behavior are present in many others cryptocurrencies.

Why not create a new field in config.json:

{
   "node": {
          ....
          "network_mode": "C", // Switch between network modes. A = Test, B = Beta, C = Live
          ....
   }
}

It's possible?

@rkeene rkeene added the enhancement label Aug 24, 2018

@rkeene rkeene added this to the V19.0 milestone Aug 24, 2018

@rkeene

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2018

It is possible, and we have been wanting to make this change for a while but have not implemented to-date. We will make this change in the future. Thank you for the contribution !

@cryptocode

This comment has been minimized.

Copy link
Collaborator

commented Feb 12, 2019

A CLI option might be best here, allowing config files for the chosen network to be created on startup.

  • live/beta repweights must be handled, these are currently compiled in
  • the nano lib gets the build flag passed in. This must probably become a runtime parameter.
@wezrule

This comment has been minimized.

Copy link
Collaborator

commented Feb 12, 2019

Bitcoin has -testnet and Ethereum has --testnet which can be used as CLI options. Would be good to be consistent, although we use the term beta for this purpose, so could be some confusion between our test network.. --betanet & --testnet? Would also need it for the wallet, and a GUI option to change.

@cryptocode

This comment has been minimized.

Copy link
Collaborator

commented Feb 12, 2019

We should probably keep the flag names consistent with terms used within the Nano community, regardless of what other projects do. So simply livenet, betanet and testnet IMO.

@wezrule

This comment has been minimized.

Copy link
Collaborator

commented Feb 12, 2019

Yes agreed, but we should also try and maintain some form of consistency with naming if there are acceptable standards adopted by projects already, just to make multi node service's lives easier. I don't think livenet is necessary as it should be the default. But what do do if someone specifies both nano_node --daemon --testnet --betanet? Guess betanet makes more sense to have priority here or just exit with an error saying it is ambiguous

@cryptocode

This comment has been minimized.

Copy link
Collaborator

commented Feb 12, 2019

Yeah I think multiple nets should be an error.

@cryptocode cryptocode added this to CP0 in V19 Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.