Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add own protocol version to RPC version action #1189

Closed
BitDesert opened this issue Sep 15, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@BitDesert
Copy link
Contributor

commented Sep 15, 2018

It would be nice if the protocol version would be returned via RPC:

Request:

{  
  "action": "version" 
}

Response:

{
    "rpc_version": "1",
    "store_version": "11",
    "protocol_version": "14",
    "node_vendor": "RaiBlocks 16.0"
}

The variable is set here: https://github.com/nanocurrency/raiblocks/blob/c03351b8ba246c6b6a856996178c97d5e8964b9f/rai/secure/common.hpp#L28

I'm lacking C++ knowledge so I can't create a PR but with this change I could add it to the Nano Node Monitor ( https://github.com/NanoTools/nanoNodeMonitor ). The network version does not always match the node version e.g. v16.0RC2 has the protocol version 13, v16.0 release has 14. Thanks!

@rkeene rkeene added the enhancement label Sep 15, 2018

@rkeene rkeene added this to the V18.0 milestone Sep 15, 2018

argakiig added a commit to argakiig/raiblocks that referenced this issue Sep 16, 2018

@rkeene rkeene modified the milestones: V18.0, V17.0 Oct 12, 2018

@rkeene

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2018

This work has been done as part of pull request #1194 and will be in V17.0. I'm closing this ticket based on the future release of V17.0.

Thanks !

@rkeene rkeene closed this Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.