Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC linker error rai_bootstrap_weights #1316

Closed
CathalT opened this issue Oct 20, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@CathalT
Copy link
Contributor

commented Oct 20, 2018

This issue has been around for a while, I see that its been mentioned before:
#747

Current workaround is a script to replace the variables in node.cpp.

I've raised a bug on visual studio and its currently under investigation:
https://developercommunity.visualstudio.com/content/problem/359987/declaring-local-extern-variable-causes-linker-erro.html

Changing the variables to globals under the "rai" namespace fixes the issue.
I think this might be preferable to the script.

e.g.

namespace rai
{
extern unsigned char rai_bootstrap_weights[];
extern size_t rai_bootstrap_weights_size;
}

I'll open a PR and see what you think, if there's some reason not to make the variables global (well the definition is already global in bootstrap_weights.cpp).

@rkeene

This comment has been minimized.

Copy link
Contributor

commented Oct 22, 2018

Thanks for your work on this !

@rkeene rkeene closed this Oct 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.