Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track down potential memory leak with rai::vote #1471

Closed
rkeene opened this issue Dec 17, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@rkeene
Copy link
Contributor

commented Dec 17, 2018

A possible memory leak has been observed. When bootstrapping a node on the live network, the vote uniquer votes container exceeds 1M entries, which is a bit unusual.

@rkeene rkeene added the bug label Dec 17, 2018

@rkeene rkeene added this to the V17.0 milestone Dec 17, 2018

@rkeene

This comment has been minimized.

Copy link
Contributor Author

commented Dec 17, 2018

Tracked this down to an issue with the vote uniquer.

The vote uniquer was calls votes.find(randomHash) which pretty much always returns votes.end(), which it rewrites to votes.begin() and thus would only ever delete references when votes.begin() was free-able.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.