Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate periodic bootstrap slowness #1474

Closed
rkeene opened this issue Dec 18, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@rkeene
Copy link
Contributor

commented Dec 18, 2018

Some users have reported issues bootstrapping V17.0RC3 -- investigate and resolve before V17.0 final

@rkeene rkeene added the bug label Dec 18, 2018

@rkeene rkeene added this to the V17.0 milestone Dec 18, 2018

@rkeene

This comment has been minimized.

Copy link
Contributor Author

commented Dec 18, 2018

Improvements to bootstrap block processing:

  • In process_receive_many(), in addition to should_log() log the first time through the while loop
  • Ensure process_receive_many() is called no more frequently than 100ms
  • When process_receive_many() finishes, log a summary (gated behind some sort of logging configuration option)
  • Pull request #1450
  • Pull request #1459 (with revisions) ?
  • Don't perform (block) signature checking on a separate thread -- it's not helpful (unless the work is split up and multithreaded), revert pull request #1411 for V17 (still on master)
  • Log timing information from verify_state_blocks() (gated behind some sort of logging configuration option)
@rkeene

This comment has been minimized.

Copy link
Contributor Author

commented Dec 18, 2018

This should be resolved.

@rkeene rkeene closed this Dec 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.