Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki improvements (mostly boost related) #1508

Closed
5 tasks done
wezrule opened this issue Dec 28, 2018 · 1 comment
Closed
5 tasks done

Wiki improvements (mostly boost related) #1508

wezrule opened this issue Dec 28, 2018 · 1 comment
Assignees
Labels
documentation This item indicates the need for or supplies updated or expanded documentation
Projects
Milestone

Comments

@wezrule
Copy link
Contributor

wezrule commented Dec 28, 2018

  • In Build-Instructions it mentions util/bootstrap_boost.sh, however this is actually located in util/build_prep/bootstrap_boost.sh. Under OSX of Build-rai_node-samples it also mentions the non-existent filepath:
    sh ci/bootstrap_boost.sh

  • There is an inconsistency in building the boost libraries, some don't use --with-libraries, and the ones that do mention unnecessary libraries. For instance:

Build-rai_node-samples - This uses: --with-libraries=filesystem,iostreams,log,program_options,thread in two places, but is also not mentioned near the bottom! (under Ubuntu 16.04). iostreams is not used in bootstrap_boost.sh, so can be removed.

Build-rai_node-samples-ARM and Ubuntu-16.04 build all boost libraries.

Install-Wallet-on-Ubuntu-16.04.3 mentions the same five as in Build-rai_node-samples so iostreams can be removed.

docker/ci/Dockerfile builds all boost libraries as well. I have created #1507 for this.

util/build_prep/bootstrap_boost.sh -m should be used where possible.

@zhyatt zhyatt added the documentation This item indicates the need for or supplies updated or expanded documentation label Jan 2, 2019
@zhyatt zhyatt added this to the V18.0 milestone Jan 7, 2019
@zhyatt zhyatt added this to Unscheduled in V18 Jan 7, 2019
@wezrule wezrule moved this from Unscheduled to CP 1 (2018-01-09) in V18 Jan 8, 2019
@wezrule
Copy link
Contributor Author

wezrule commented Jan 8, 2019

Made the necessary changes to the wiki. Haven't tested all the platforms, but I kept the scope as contained as possible so it should be ok.

@wezrule wezrule closed this as completed Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This item indicates the need for or supplies updated or expanded documentation
Projects
No open projects
V18
CP 1 (2018-01-09)
Development

No branches or pull requests

2 participants