Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add size field to bootstrap message types #1529

Closed
cryptocode opened this issue Jan 1, 2019 · 0 comments

Comments

Projects
2 participants
@cryptocode
Copy link
Collaborator

commented Jan 1, 2019

In a similar vein to #1528

Then reference that field instead of e.g. size_t size_l (sizeof (nano::uint256_union) + sizeof (nano::uint256_union)); at call sites.

Some requests have variable size (based on header fields) so it'll be a function rather than a constexpr.

@cryptocode cryptocode self-assigned this Jan 1, 2019

@cryptocode cryptocode added this to the V18.0 milestone Jan 1, 2019

@cryptocode cryptocode added this to CP 0 in V18 Jan 1, 2019

@cryptocode cryptocode moved this from CP 0 to CP 1 (2018-01-09) in V18 Jan 1, 2019

@cryptocode cryptocode moved this from CP 1 (2018-01-09) to CP 2 (2018-01-16) in V18 Jan 9, 2019

@rkeene rkeene closed this in #1580 Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.