Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FindBoost.cmake #1597

Closed
rkeene opened this issue Jan 16, 2019 · 2 comments

Comments

Projects
3 participants
@rkeene
Copy link
Contributor

commented Jan 16, 2019

Newer versions of Boost need newer FindBoost.cmake, apparently -- verify and update.

@rkeene rkeene added this to the V18.0 milestone Jan 16, 2019

@wezrule

This comment has been minimized.

Copy link
Collaborator

commented Jan 16, 2019

When I was doing the docker update, I tried using boost 1.69 which worked ok, but it did spit out some warning because our FindBoost is hardcoded to support max 1.68 IIRC

@argakiig

This comment has been minimized.

Copy link
Collaborator

commented Jan 16, 2019

the included FindBoost.cmake was protected with a boolean when it was initially added to allow the locally sourced version to be used. This was when 1.67 changed the windows lib format but cmake hadnt published an official updated FindBoost.cmake

As long as the system cmake is sufficiently updated I dont think it would be necessary to maintain our own copy, would it be better to instead provide an updated minimum for cmake?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.