Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all versions of GCC support -fsanitize-blacklist #1656

Closed
rkeene opened this issue Jan 28, 2019 · 3 comments

Comments

5 participants
@rkeene
Copy link
Contributor

commented Jan 28, 2019

TSAN blacklist support (added in #1637) is not available in all versions of GCC.

@rkeene rkeene added the build-error label Jan 28, 2019

@cryptocode

This comment has been minimized.

Copy link
Collaborator

commented Jan 28, 2019

@rkeene Should I introduce a cmake flag for it? Without it, tsan is just too noisy to be practical.
edit: could maybe just add it to #1655

@rkeene

This comment has been minimized.

Copy link
Contributor Author

commented Jan 28, 2019

Ideally the build system would detect whether or not the compiler supports this.

@zhyatt zhyatt added this to the V18.0 milestone Feb 11, 2019

@zhyatt zhyatt added this to During RC in V18 Feb 11, 2019

@zhyatt zhyatt moved this from RC2 to RC3 in V18 Feb 18, 2019

@wezrule wezrule added this to CP0 in V19 Feb 19, 2019

@zhyatt zhyatt removed this from RC3 (2019-02-18) in V18 Feb 22, 2019

@zhyatt zhyatt modified the milestones: V18.0, V19.0 Feb 22, 2019

@zhyatt zhyatt assigned argakiig and unassigned wezrule Feb 22, 2019

@zhyatt zhyatt moved this from CP0 to CP1 in V19 Feb 28, 2019

@zhyatt zhyatt moved this from CP1 (2019-03-13) to CP3 (2019-04-10) in V19 Mar 27, 2019

@zhyatt zhyatt moved this from CP3 (2019-04-10) to During RC in V19 Apr 11, 2019

@wezrule

This comment has been minimized.

Copy link
Collaborator

commented Apr 27, 2019

gcc does not support this option, but you can use a suppressions file in the TSAN_OPTIONS environment variable:
#1941
Documentation: https://github.com/nanocurrency/nano-node/wiki/Testing

@wezrule wezrule closed this Apr 27, 2019

@zhyatt zhyatt moved this from During RC to RC2 (2019-05-06) in V19 May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.