Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC wallet_change_seed should return the first account created #1717

Closed
guilhermelawless opened this issue Feb 11, 2019 · 3 comments

Comments

2 participants
@guilhermelawless
Copy link
Contributor

commented Feb 11, 2019

It can get confusing to users when they don't see the account returned, and on the first account_create afterwards, the second account is returned.

This would also make it consistent with wallet_create with a given seed.

@SergiySW

This comment has been minimized.

Copy link
Collaborator

commented Feb 11, 2019

wallet_create+seed is returning last restored account. Makes sense

@guilhermelawless

This comment has been minimized.

Copy link
Contributor Author

commented Feb 11, 2019

Yes, but wallet_change_seed only returns "success": ""

SergiySW added a commit to SergiySW/raiblocks that referenced this issue Feb 11, 2019

@SergiySW SergiySW self-assigned this Feb 11, 2019

@SergiySW SergiySW added this to the V19.0 milestone Feb 11, 2019

@SergiySW SergiySW added this to CP0 in V19 Feb 19, 2019

SergiySW added a commit that referenced this issue Feb 22, 2019

@SergiySW

This comment has been minimized.

Copy link
Collaborator

commented Feb 22, 2019

Impropved in #1718

@SergiySW SergiySW closed this Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.