Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Boost 1.70 #1914

Closed
cryptocode opened this issue Apr 23, 2019 · 0 comments

Comments

1 participant
@cryptocode
Copy link
Collaborator

commented Apr 23, 2019

Boost 1.70 has some breaking changes, requiring conditional compilation to support older versions.

Known so far:

Boost Beast:

  • buffer -> make_printable (from release notes: buffers is spelled make_printable. Actions Required: Replace buffers with make_printable, and include "make_printable.hpp" instead of "ostream.hpp")
  • websocket template arguments have changed

The recommended fix is

#if BOOST_VERSION < 107000
using socket_type = boost::asio::ip::tcp::socket;
#else
using socket_type = boost::asio::basic_socket<boost::asio::ip::tcp, boost::asio::io_context::executor_type>;
#endif

and then pass socket_type to websocket

@cryptocode cryptocode self-assigned this Apr 23, 2019

@cryptocode cryptocode added this to the V19.0 milestone Apr 23, 2019

@cryptocode cryptocode added this to During RC in V19 Apr 23, 2019

@zhyatt zhyatt moved this from During RC to RC2 (2019-05-06) in V19 May 6, 2019

@zhyatt zhyatt moved this from RC2 (2019-05-06) to CP3/RC 1 (2019-04-26) in V19 May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.