Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xrb_uint256_to_string does not null-terminate the address string #290

gkastel opened this issue Dec 27, 2017 · 3 comments


3 participants

This comment has been minimized.

Copy link

commented Dec 27, 2017

The idea with this was that someone could put this number in to the middle of a string without having the null character clobber something.

// Convert public/private key bytes 'source' to a 64 byte not-null-terminated hex string 'destination'
void xrb_uint256_to_string (const xrb_uint256 source, char * destination);


This comment has been minimized.

Copy link

commented Dec 27, 2017

@rkeene rkeene added this to the V16.0 milestone Aug 23, 2018

@rkeene rkeene self-assigned this Aug 23, 2018

@rkeene rkeene added the bug label Aug 24, 2018

@rkeene rkeene modified the milestones: V16.0, V17.0 Aug 29, 2018

@rkeene rkeene added the question label Sep 24, 2018

@rkeene rkeene modified the milestones: V17.0, V18.0 Oct 23, 2018


This comment has been minimized.

Copy link

commented Oct 23, 2018

I don't think we're going to reach a decision on this in time for V17.0, moving to the next release which we plan to use for cleanup and can decide how best to handle this.

@zhyatt zhyatt added this to Unscheduled in V18 Dec 27, 2018

@rkeene rkeene moved this from Unscheduled to CP 0 in V18 Dec 31, 2018

@rkeene rkeene closed this in #1223 Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.