Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`cpack` release includes miniupnp headers #629

Closed
androm3da opened this issue Feb 16, 2018 · 4 comments

Comments

Projects
5 participants
@androm3da
Copy link
Contributor

commented Feb 16, 2018

When using cpack to make tarball, it includes the miniupnpc header tree.

One item I saw is that if we defined the target_link_libraries as PRIVATE it might eliminate this effect.

@androm3da androm3da added the bug label Feb 16, 2018

@PlasmaPower

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2018

The OSX dmg also contains the cryptopp and miniupnpc headers.

@argakiig

This comment has been minimized.

Copy link
Collaborator

commented Feb 16, 2018

windows as well

@paulmelis

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2018

A regular "make install" on linux also includes them in include/miniupnpc

@rkeene rkeene added this to the V18.0 milestone Aug 23, 2018

@zhyatt zhyatt added this to Unscheduled in V18 Dec 27, 2018

@argakiig argakiig moved this from Unscheduled to CP 2 (2018-01-16) in V18 Dec 28, 2018

@argakiig

This comment has been minimized.

Copy link
Collaborator

commented Feb 5, 2019

closed with #1701

@argakiig argakiig closed this Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.