Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Issues detect by valgrind #654
Here is the output of running valgrind on a debug build of a fresh git clone on ubuntu 14.04 64bits.
I read the code around this failure a bit and it seems like this could be due to a lack of proper error checking.
If you look at how 'block_store' initializes its 'environment' variable:
It gets 'error_a' back as 'true' if it failed to initialize the 'environment' object. However, we never check if the 'environment' is valid before using it. I'm guessing when we pass that all the way up to rai::transaction::transaction(...), it goes into LMDB (via mdb_txn_begin()) and crashes inside, since the contract expects a pre-allocated 'mdb_env' object.
Old issue seems fixed.
By default for node it's 128GB, so running valgring requires small changes
Valgrind detected a few more issues, so leave it open