Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The statement is always true in 'rai::active_transactions::announce_votes' ? #724

Closed
huye0728 opened this issue Mar 12, 2018 · 5 comments

Comments

Projects
6 participants
@huye0728
Copy link
Contributor

commented Mar 12, 2018

size_t announcements(0)
{
...
for (; i != n && announcements < announcements_per_interval; ++i)
{
...
// lost announcements ++ in loop, announcements < announcements_per_interval always true
}
}
// lost announcements ++ in loop???

@PlasmaPower

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2018

Oh that's an interesting bug. To sum it up announcements is never incremented.

@huye0728

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2018

if this is a bug, i think 'announcements_per_interval = 32' is too small, because 'announce_interval_ms = (rai::rai_network == rai::rai_networks::rai_test_network) ? 10 : 16000', only 32 blocks republished every 16 seconds?

@PlasmaPower

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2018

Yeah it's definitely too small, so it's a good thing that it isn't currently working. There are some better WIP rate limiting solutions.

@rkeene rkeene added this to the V18.0 milestone Aug 23, 2018

@rkeene rkeene added the bug label Aug 23, 2018

@Shrey33

This comment has been minimized.

Copy link

commented Sep 15, 2018

@huye0728 what can we achieve using this bug ?

@rkeene rkeene assigned SergiySW and unassigned argakiig Dec 20, 2018

@zhyatt zhyatt added this to Unscheduled in V18 Dec 27, 2018

@SergiySW

This comment has been minimized.

Copy link
Collaborator

commented Dec 28, 2018

@SergiySW SergiySW closed this Dec 28, 2018

@SergiySW SergiySW moved this from Unscheduled to CP 0 in V18 Dec 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.