Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release asset: official Docker image #754

Closed
cbrunnkvist opened this issue Mar 26, 2018 · 9 comments

Comments

Projects
5 participants
@cbrunnkvist
Copy link

commented Mar 26, 2018

Description of bug:

I want to run the client inside of a docker container, keeping the blockchain, config and keys on separate volumes.

Steps to reproduce the issue:

  1. Go to https://github.com/nanocurrency/raiblocks/releases
  2. Look for the link to the latest docker image & a template / instructions for how to extend it with your own Dockerfile or via a docker-compose.yml file
  3. It currently doesn't exist 🙁

Describe the results you received:

Neither of the searches https://hub.docker.com/search/?isAutomated=0&isOfficial=0&page=1&pullCount=0&q=nano&starCount=0 or https://hub.docker.com/search/?isAutomated=0&isOfficial=0&page=1&pullCount=0&q=raiblocks&starCount=0 return any conclusive results.

Describe the results you expected:

Additional information you deem important (e.g. issue happens only occasionally):

Until there is a clear, correctly named, automatically built official image, there is a good opportunity for someone to upload a hacked image to the hub in order to steal peoples funds etc.

Environment:

  • Any OS running a recent version of Docker

logs

(n/a)

@PlasmaPower

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2018

As documented in the wiki, the official image is nanocurrency/nano. Is there anywhere else you'd like to see it documented?

@cbrunnkvist

This comment has been minimized.

Copy link
Author

commented Mar 26, 2018

Wiki!? Wow 👓 I didn't find that, since it is merely linked as the final bullet point in a long list under "Links & Resources" of the README...

So to answer the question: yes, I think it would be reasonable to see, under the "Looking to start a node?"-section on nano.org, the link "Grab the Linux build here:" be followed by "...or run in a Docker container"

@cbrunnkvist

This comment has been minimized.

Copy link
Author

commented Mar 26, 2018

...and like the subject says: It would reinforce the officialness had the link to the nanocurrency/nano image been included each time in the Release notes or attached as an asset

@cbrunnkvist

This comment has been minimized.

Copy link
Author

commented Mar 26, 2018

Third but not least: https://hub.docker.com/u/nanocurrency/ looks completely anonymous and is from a Docker hub users perspective completely undocumented. I'm not sure I would've pulled from there...

@cclafferty

This comment has been minimized.

Copy link

commented Mar 26, 2018

+1 the project would benefit if 'nanocurrency' user gains official status on Docker Hub.

As with all best practices on Docker Hub there should be a link to the source repository, a link to the Dockerfile used to build the image and more comprehensive description of the project.
No doubt these would come in time. Right now though some people may be hesitant to run the docker image.

I chose not to run that image until I read the instructions on the Milestone 11 annoucement which specifically references nanocurrency/nano.

Given how easy it is to change a wiki I wouldn't use that as any source of validity.

@renesq

This comment has been minimized.

Copy link

commented Mar 26, 2018

Some side note: I realised that the Docker Hub files are binary already, you can't really see what's in them. So the hidden nanocurrency/nano-beta:master docker Hub instructions file is not 100% open source, is it?

@PlasmaPower

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2018

It's as open source as any other binary, e.g. Firefox.

In addition, if you try building the Dockerfile yourself, you should theoretically get the same product.

@rkeene rkeene self-assigned this Aug 23, 2018

@rkeene rkeene added this to the V18.0 milestone Aug 23, 2018

@rkeene

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2018

Related issue #863

@zhyatt zhyatt added this to Unscheduled in V18 Dec 27, 2018

@rkeene

This comment has been minimized.

Copy link
Contributor

commented Dec 28, 2018

I have added a link to the wiki page in the Release V17.0 releases and we'll keep that link in the future release announcements. Since we are constantly working on this software and systems, we miss important bits of perspective on what it looks like from the outside. Thank you for helping us !

@rkeene rkeene closed this Dec 28, 2018

@zhyatt zhyatt moved this from Unscheduled to CP 0 in V18 Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.