Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop test nodes with deadline expired #1152

Merged
merged 7 commits into from Oct 23, 2018

Conversation

Projects
None yet
2 participants
@SergiySW
Copy link
Collaborator

commented Sep 6, 2018

When tests fail due to a deadline expiration, the node objects are not accounted for and cleaned up. This causes subsequent tests to fail because they cannot initialize a node (due to port being already in use) and failures are cluttered with false positives.

@rkeene rkeene added this to the V17.0 milestone Sep 10, 2018

@rkeene rkeene self-requested a review Sep 10, 2018

@rkeene

rkeene approved these changes Oct 23, 2018

Copy link
Contributor

left a comment

Thanks !

@rkeene rkeene merged commit 00a147f into nanocurrency:master Oct 23, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.