Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "latest-including-rc" tag for Docker #1193

Merged
merged 2 commits into from Oct 25, 2018

Conversation

Projects
None yet
4 participants
@BitDesert
Copy link
Contributor

commented Sep 16, 2018

So we can pull the "latest-rc" tag that points to the latest release candidate.

Add "latest-rc" tag for Docker
So we can pull the "latest-rc" tag that points to the latest release candidate

@argakiig argakiig added enhancement ci/cd and removed ci/cd labels Sep 16, 2018

@rkeene

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2018

The disadvantage of this is that it will sometimes be the case that "latest-rc" is older than "latest" and sometimes be the case that "latest" is older than "latest-rc".

I think a better solution would be to create a new tag that either points to "latest" or the proposed "latest-rc", depending on which is newer -- something like "unstable".

@rkeene rkeene added this to the V17.0 milestone Sep 19, 2018

@severalif

This comment has been minimized.

Copy link

commented Sep 19, 2018

@rkeene The issue right now is that the nodes (the official etc) on the beta network run v16rc2, which is older than the latest release (v16), and this in combination with that nodes on the beta network de-peer when the protocol version differs. Thus, if you use the latest tag for beta network, then you will run v16 and get no peers. If you add peers manually, then you get issues with block confirmation since there are not enough reps using v16.

It's not really clear what version we should run on the beta network. One response we got from core in the Discord channel beta-net was that we should only run release candidates (not releases if they are newer). That's why Desert created this PR.

For me it makes more sense to run the latest release candidate or latest release depending on which one is newer (thus, an unstable tag).

@rkeene rkeene self-assigned this Oct 22, 2018

Change tag to "latest-including-rc"
Change tag to "latest-including-rc" and apply it non-RCs.  This tag will either point to the latest RC or the latest release, which ever has been tagged more recently.

@rkeene rkeene merged commit 339afd7 into nanocurrency:master Oct 25, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@rkeene rkeene changed the title Add "latest-rc" tag for Docker Add "latest-including-rc" tag for Docker Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.