Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero-terminate all things we refer to as strings #1223

Merged
merged 3 commits into from Jan 2, 2019

Conversation

Projects
3 participants
@rkeene
Copy link
Contributor

commented Sep 24, 2018

Fixes #290

@rkeene rkeene added this to the V17.0 milestone Sep 24, 2018

@rkeene rkeene self-assigned this Sep 24, 2018

@cryptocode

This comment has been minimized.

Copy link
Collaborator

commented Sep 24, 2018

Do we want rust-rai-lib to match the updated semantics? It's based on the same header IIRC (@PlasmaPower?), maybe a source of confusion if they differ.

@PlasmaPower

This comment has been minimized.

Copy link
Contributor

commented Sep 24, 2018

I don't love making a very breaking change to rai_lib. Maybe add a version suffix?

But yes rust-rai-lib should be a drop-in replacement for rai_lib.

@rkeene

This comment has been minimized.

Copy link
Contributor Author

commented Sep 24, 2018

You mean version the symbol (does Windows support this?; do we even create a shared object ?) or create a new symbol with a different name and different semantics ?

@rkeene

This comment has been minimized.

Copy link
Contributor Author

commented Oct 23, 2018

I don't think we're going to reach a decision on this in time for V17.0, moving to the next release which we plan to use for cleanup and can decide how best to handle this.

@rkeene rkeene modified the milestones: V17.0, V18.0 Oct 23, 2018

@zhyatt zhyatt added this to Unscheduled in V18 Dec 27, 2018

@rkeene rkeene force-pushed the rkeene:null-terminate-c-strings branch from 7777b0b to 841cfa7 Dec 28, 2018

@rkeene rkeene moved this from Unscheduled to CP 0 in V18 Dec 31, 2018

@rkeene rkeene merged commit 9526f64 into nanocurrency:master Jan 2, 2019

rkeene added a commit to rkeene/nano-node that referenced this pull request Jan 2, 2019

@rkeene rkeene referenced this pull request Jan 2, 2019

Merged

Fix too-small buffer #1541

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.