Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Docker, log output to a file (unrotated !) #1228

Merged
merged 3 commits into from Jan 14, 2019

Conversation

Projects
5 participants
@rkeene
Copy link
Contributor

commented Sep 24, 2018

Within Docker, we don't capture the output so users may have a hard-time finding information about failed release_assert () s which #1226 added even more of

@rkeene rkeene self-assigned this Sep 24, 2018

@rkeene rkeene requested a review from cryptocode Sep 24, 2018

@PlasmaPower

This comment has been minimized.

Copy link
Contributor

commented Sep 24, 2018

Couldn't we just enable log_to_cerr in the default config?

@rkeene

This comment has been minimized.

Copy link
Contributor Author

commented Sep 24, 2018

This was to catch information about failed release_asserts () -- I'll update the description

@rkeene

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2018

Maybe we should rotate this log file before merging this.

@rkeene rkeene added this to the V18.0 milestone Oct 9, 2018

@rkeene rkeene added the incomplete label Oct 9, 2018

@zhyatt zhyatt added this to Unscheduled in V18 Dec 27, 2018

@rkeene rkeene moved this from Unscheduled to CP 0 in V18 Dec 31, 2018

@rkeene rkeene requested a review from cryptocode Jan 2, 2019

@cryptocode
Copy link
Collaborator

left a comment

Code looks fine to me; I haven't tested the rotation, maybe someone could do that?

@zhyatt zhyatt requested a review from argakiig Jan 7, 2019

@argakiig
Copy link
Collaborator

left a comment

Builds and rotates properly should be enough buffer to catch any errors from the container itself

@zhyatt zhyatt removed the incomplete label Jan 14, 2019

@zhyatt zhyatt merged commit bfd89e8 into nanocurrency:master Jan 14, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.