Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC "sign" (hash, block) #1241

Merged
merged 35 commits into from Jan 28, 2019

Conversation

Projects
4 participants
@SergiySW
Copy link
Collaborator

commented Sep 27, 2018

Allowing to sign hash or block with private key

SergiySW added some commits Sep 27, 2018

RPC sign
Signing hash or block

@SergiySW SergiySW requested a review from rkeene Sep 27, 2018

SergiySW added some commits Sep 27, 2018

@SergiySW SergiySW changed the title RPC "sign" RPC "sign_hash" & "sign_block" Sep 27, 2018

@rkeene rkeene added this to the V17.0 milestone Sep 27, 2018

@rkeene rkeene added the enhancement label Sep 27, 2018

@cryptocode

This comment has been minimized.

Copy link
Collaborator

commented Sep 27, 2018

Instead of two separate actions, could this be a single general action (kind of like #647) so it can be used to sign anything? The message can be a block or hash, but also whatever the caller wants.

@SergiySW

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 27, 2018

It was initially (hash & block in one RPC "sign", later may be messages). But @rkeene don't like it

@rkeene

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2018

Let's move this to V18.0 for now so we can figure out what semantics are best !

@rkeene rkeene modified the milestones: V17.0, V18.0 Oct 9, 2018

@zhyatt zhyatt added this to Unscheduled in V18 Dec 27, 2018

SergiySW added some commits Dec 28, 2018

@SergiySW SergiySW moved this from Unscheduled to CP 0 in V18 Dec 28, 2018

@zhyatt zhyatt added enhancement and removed enhancement labels Dec 28, 2018

@zhyatt zhyatt moved this from CP 2 (2018-01-16) to CP 3 (2018-01-23) in V18 Jan 16, 2019

@SergiySW SergiySW changed the title RPC "sign_hash" & "sign_block" RPC "sign" (hash, block) Jan 17, 2019

SergiySW added some commits Jan 18, 2019

@rkeene

This comment has been minimized.

Copy link
Contributor

commented Jan 24, 2019

Gives some UBSan errors /home/rkeene/devel/nano-node/nano/lib/jsonconfig.hpp:241:17: runtime error: load of value 110, which is not a valid value for type 'bool'

@SergiySW

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 24, 2019

@rkeene hopefully fixed

Show resolved Hide resolved nano/node/rpc.cpp Outdated
Show resolved Hide resolved nano/node/rpc.cpp
@rkeene

rkeene approved these changes Jan 24, 2019

Copy link
Contributor

left a comment

Thanks !

@SergiySW SergiySW merged commit a2fb99e into nanocurrency:master Jan 28, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.