Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weight option and account filter to representative_online rpc cal… #1300

Merged
merged 5 commits into from Oct 23, 2018

Conversation

Projects
None yet
4 participants
@CathalT
Copy link
Contributor

commented Oct 13, 2018

…l. Fixes #1192

@CathalT

This comment has been minimized.

Copy link
Contributor Author

commented Oct 13, 2018

If weight flag is set to true the json response will be in the following format:

{
    "representatives": {
        "xrb_14nfwekkenidj3nczefx5snpe6do6d49e4f33cpaeqdq59hkc6tc6wxwkem5": {
            "weight": "10000"
        },
        "xrb_1cmtk7x7eeicbe434tqcjzhdiwxkaqdntbfj1tgxmufyidcdjw3wuk5p67d1": {
            "weight": "50000"
        },
        "xrb_1beta4nkzb3g6b1a1qhae89earmz3gk3kfrp3f8hyztm8qyjkeyz9kajfutq": {
            "weight": "1300"
        },
        "xrb_1beta5zm6rq4ghp6c9n99j8fz3am8e44dewae5ea7addsjtfo8umsafmr1r7": {
            "weight": "2000"
        }
    }
}
@cryptocode

This comment has been minimized.

Copy link
Collaborator

commented Oct 13, 2018

@CathalT

This comment has been minimized.

Copy link
Contributor Author

commented Oct 13, 2018

Hmm , will look into that failure, it was passing locally...

@CathalT

This comment has been minimized.

Copy link
Contributor Author

commented Oct 13, 2018

Ah looks like a timing issue, I see there are deadline / poll functions.

@rkeene rkeene self-requested a review Oct 15, 2018

@rkeene rkeene self-assigned this Oct 15, 2018

@rkeene rkeene added the enhancement label Oct 15, 2018

@rkeene rkeene requested review from PlasmaPower and removed request for rkeene Oct 15, 2018

@rkeene rkeene assigned PlasmaPower and unassigned rkeene Oct 15, 2018

@PlasmaPower
Copy link
Contributor

left a comment

Other than that LGTM

Show resolved Hide resolved rai/node/rpc.cpp

CathalT added some commits Oct 16, 2018

@rkeene rkeene added this to the V17.0 milestone Oct 16, 2018

@rkeene rkeene merged commit a51e832 into nanocurrency:master Oct 23, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@CathalT CathalT deleted the CathalT:rep_online_weight branch Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.