Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New unit labels from legacy XRB to NANO style #1301

Merged
merged 1 commit into from Oct 17, 2018

Conversation

Projects
None yet
6 participants
@elliottminns
Copy link
Contributor

commented Oct 13, 2018

Updates the GUI labelling to use NANO, Mnano, knano and nano instead of XRB, Mxrb, kxrb and xrb respectively.

@cryptocode
Copy link
Collaborator

left a comment

Maybe the variable names (mrai, krai, rai) should match the new units, possibly with a _unit suffix (for instance mrai_unit). What do you think @elliottminns ?

@elliottminns

This comment has been minimized.

Copy link
Contributor Author

commented Oct 13, 2018

I think that makes sense. It's definitely worthwhile to change the xrb/rai references inside the QT context in one PR.

@elliottminns elliottminns force-pushed the elliottminns:feature/unit-labelling branch 2 times, most recently from c04c624 to c69c32c Oct 13, 2018

@elliottminns elliottminns force-pushed the elliottminns:feature/unit-labelling branch from c69c32c to 24ec158 Oct 13, 2018

@renesq

This comment has been minimized.

Copy link

commented Oct 14, 2018

To me, it seemed like those units are not pursued anymore, since the NANO developer guide has removed almost any reference to those kind of units. But they still exist in the old FAQ. They obviously did more harm than good, as they were incredibly confusing and weren't eliminated after each of the unit changes (rai->xrb->nano). This has lead the community to even introduce their own units like "naneroo" instead of small-caps-nano.

A better choice in my opinion would be to use NANO, mNANO and µNANO instead of NANO/Mnano, knano and nano. Or officially introduce new names for fractions of NANO. Or make the Qt wallet compatible with decimals and/or raw 🤔

@cryptocode

This comment has been minimized.

Copy link
Collaborator

commented Oct 14, 2018

@rotilho

This comment has been minimized.

Copy link

commented Oct 14, 2018

I think the nano Nano are really confusing, I recently mixed both when developing jnano-client.

I decided to call nano "small nano" but it would be really nice have some kind of prefix for it like snano and keep MNano as just Nano

@pedfx

This comment has been minimized.

Copy link

commented Oct 15, 2018

I agree it should call the nano = 1000000000000000000000000, 10^24 snano (or another letter before nano)

So we don't have any unit being called just Nano or nano or NANO, that is the most confusing thing possible.

It would be called Nano/NANO/nano just for the currency name and not used on any unit alone.

@cryptocode

This comment has been minimized.

Copy link
Collaborator

commented Oct 17, 2018

The Qt wallet doesn't support decimals and this PR correctly uses the units defined in https://github.com/nanocurrency/raiblocks/wiki/Distribution,-Mining-and-Units#divider. A new PR can be made if we decide on new units or add decimal input support.

@cryptocode cryptocode merged commit a2cbb0a into nanocurrency:master Oct 17, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rkeene rkeene added this to the V17.0 milestone Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.