Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSVC linker error using rai_bootstrap_weights #1317

Merged
merged 4 commits into from Oct 22, 2018

Conversation

Projects
None yet
3 participants
@CathalT
Copy link
Contributor

commented Oct 20, 2018

see #1316

@argakiig argakiig self-requested a review Oct 21, 2018

@argakiig
Copy link
Collaborator

left a comment

I like this, the work around for windows was hacky, and was due to a bug/lack of support in MSVC, seems to be working in my testing as well, Thank you 👍

@CathalT

This comment has been minimized.

Copy link
Contributor Author

commented Oct 21, 2018

No problem! Glad to help , I'm mainly a Windows dev myself so it it was definitely self beneficial haha

@rkeene rkeene added this to the V17.0 milestone Oct 22, 2018

@rkeene rkeene merged commit 960cc17 into nanocurrency:master Oct 22, 2018

@CathalT CathalT deleted the CathalT:vs_linker_bug branch Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.