Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert race workaround #1318

Merged
merged 2 commits into from Oct 22, 2018

Conversation

Projects
None yet
3 participants
@clemahieu
Copy link
Collaborator

commented Oct 21, 2018

No description provided.

clemahieu added some commits Oct 21, 2018

Blocks can be added to active_transactions before the ledger write tr…
…ansaction has been flushed to the disk.

Don't run the election cleanup procedure until after at least 1 announcement interval has gone by to work around this situation.

@clemahieu clemahieu requested a review from SergiySW Oct 21, 2018

@PlasmaPower

This comment has been minimized.

Copy link
Contributor

commented Oct 21, 2018

IMO either stopped should be set when confirmed is set, or stopped should be a method that returns confirmed || aborted.

@clemahieu

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 22, 2018

Let's do that as a followup patch. This is just a rename and workaround for the tx commit race condition.

1 similar comment
@clemahieu

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 22, 2018

Let's do that as a followup patch. This is just a rename and workaround for the tx commit race condition.

@clemahieu clemahieu merged commit 024019d into master Oct 22, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@clemahieu clemahieu deleted the insert_race_workaround branch Oct 22, 2018

@rkeene rkeene added this to the V17.0 milestone Oct 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.