Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unreachable host stats #1329

Merged
merged 1 commit into from Oct 24, 2018

Conversation

Projects
None yet
3 participants
@cryptocode
Copy link
Collaborator

commented Oct 23, 2018

This catches ICMP rejects from firewalls too.

Seems like we keep trying to send to quite a few endpoints that we'll probably never be able to contact. Should maybe add a backoff on these endpoint (they may be down and get back up)

Adding stats for now.

@rkeene rkeene requested a review from icarusglider Oct 23, 2018

@rkeene rkeene added the enhancement label Oct 23, 2018

@rkeene rkeene added this to the V17.0 milestone Oct 23, 2018

@PlasmaPower
Copy link
Contributor

left a comment

I'm assuming this covers port unreachable?

@cryptocode

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 23, 2018

I don't think so, port unreachable is host generated and I think those map to connection_refused in asio (even for udp?). I can look into it and log connection_refused in a different PR.

@rkeene rkeene merged commit 7ea2fc6 into nanocurrency:master Oct 24, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.