Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply to confirm_reqs with a vote by hash #1335

Merged
merged 1 commit into from Nov 2, 2018

Conversation

Projects
None yet
3 participants
@PlasmaPower
Copy link
Contributor

commented Oct 28, 2018

No description provided.

@PlasmaPower PlasmaPower added this to the V17.0 milestone Oct 28, 2018

@rkeene rkeene requested a review from SergiySW Oct 29, 2018

@rkeene rkeene added the enhancement label Oct 29, 2018

@SergiySW

This comment has been minimized.

Copy link
Collaborator

commented Oct 30, 2018

Do we have a test to check efficency of sending vote for hash (fork) & then fork block? Wouldn't vote be just ignored?

@PlasmaPower

This comment has been minimized.

Copy link
Contributor Author

commented Nov 2, 2018

Nope, votes are stored by their hash, and later the hash->block table is used when votes are tallied.

@rkeene rkeene merged commit 4b6f89b into nanocurrency:master Nov 2, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rkeene rkeene added the major label Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.