Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC Account history filter #1355

Merged
merged 8 commits into from Mar 15, 2019

Conversation

@CathalT
Copy link
Contributor

commented Nov 6, 2018

Fixes #1110

@rkeene rkeene requested a review from argakiig Nov 7, 2018

@rkeene rkeene added the enhancement label Nov 7, 2018

@rkeene rkeene added this to the V19.0 milestone Nov 7, 2018

@CathalT

This comment has been minimized.

Copy link
Contributor Author

commented Nov 7, 2018

Need to have a look at those failing tests, probably timing again, seemed ok locally

@argakiig
Copy link
Collaborator

left a comment

#1110 was looking for account_history
please adjust test accordingly

Show resolved Hide resolved rai/core_test/rpc.cpp Outdated
Show resolved Hide resolved rai/core_test/rpc.cpp Outdated
@CathalT

This comment has been minimized.

Copy link
Contributor Author

commented Nov 7, 2018

Must not have ran the test with those last two lines at all my bad.
I went with creating a new test for "account_history". We should be ok now, unless you want me to refactor the tests a bit, I can spend a bit more time on it another day.

@rkeene rkeene changed the title RPC Account history filter (Issue #1110) RPC Account history filter Dec 27, 2018

@argakiig

This comment has been minimized.

Copy link
Collaborator

commented Jan 25, 2019

@CathalT can you rebase and check formatting?

@CathalT

This comment has been minimized.

Copy link
Contributor Author

commented Jan 25, 2019

Just gone on holidays for a week, I'll be back Sunday the 3rd of Feb

Add accounts filter to accounts_history rpc call. #1110
Add test for account_history account filter option.

Remove unnecessary return

Add seperate account_history test.

@CathalT CathalT force-pushed the CathalT:rpc_account_history_filter branch from befc924 to db332d5 Feb 6, 2019

CathalT and others added some commits Feb 6, 2019

Cathal Tummon
@CathalT

This comment has been minimized.

Copy link
Contributor Author

commented Feb 7, 2019

I'm having trouble building after updating to latest, cryptopp is failing to build some assembly files on windows.
Haven't got a chance to sort it out yet and there are a few more issues to sort for this PR to pass...

@argakiig argakiig added this to Unscheduled in V19 Feb 15, 2019

@CathalT

This comment has been minimized.

Copy link
Contributor Author

commented Feb 17, 2019

@argakiig those latest failures don't look related to my changes? I think we're looking good

[  FAILED  ] wallet.select_account
[  FAILED  ] wallet.seed_work_generation
@wezrule

This comment has been minimized.

Copy link
Collaborator

commented Feb 17, 2019

@CathalT yeh those are intermittent failures don't worry. However could you please run clang-format on your files (ci/clang-format-all.sh). You can see the diff near the top of the travis ci output complaining.

@guilhermelawless

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

@CathalT there's a conflict

CathalT added some commits Mar 13, 2019

@argakiig argakiig merged commit db4ba1f into nanocurrency:master Mar 15, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.