Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Proposal) Fix multiple rpc callbacks for same host. #1356

Merged
merged 2 commits into from Jan 7, 2019

Conversation

Projects
5 participants
@CathalT
Copy link
Contributor

commented Nov 6, 2018

#1073
Instead of looping through all resolved addresses, only iterate if there is a failure and try again.

@rkeene rkeene added this to the V18.0 milestone Nov 8, 2018

@zhyatt zhyatt added this to Unscheduled in V18 Dec 27, 2018

@cryptocode

This comment has been minimized.

Copy link
Collaborator

commented Dec 27, 2018

@CathalT any chance you could rebase this?

@CathalT

This comment has been minimized.

Copy link
Contributor Author

commented Dec 28, 2018

Will have a look this evening

@CathalT

This comment has been minimized.

Copy link
Contributor Author

commented Dec 29, 2018

Apologies lads, bit caught up over Christmas, will get around to it in the next day or two!

Fix multiple rpc callbacks for same host. Fixes #1073
Formatting.

Clang Format

Fix conflict issues

@CathalT CathalT force-pushed the CathalT:rpc_callback_fix branch from 82acf41 to e4b2bc7 Dec 30, 2018

Show resolved Hide resolved nano/node/node.cpp Outdated

@cryptocode cryptocode moved this from Unscheduled to CP 1 (2018-01-09) in V18 Jan 3, 2019

@zhyatt zhyatt merged commit 7bb35d9 into nanocurrency:master Jan 7, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@CathalT CathalT deleted the CathalT:rpc_callback_fix branch Feb 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.