Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicate a full r hash block to attacker unknown bytes #1368

Merged
merged 5 commits into from Nov 9, 2018

Conversation

Projects
None yet
3 participants
@PlasmaPower
Copy link
Contributor

commented Nov 9, 2018

Follow up to #1353. I noticed that https://eprint.iacr.org/2017/985.pdf recommended dedicating a full hash block to the key and random bytes to prevent side channel attacks (I don't recall that from the paper I had previously read). This is also similar to how keys work in blake2b, and again there's really no reason not to do it.

@PlasmaPower

This comment has been minimized.

Copy link
Contributor Author

commented Nov 9, 2018

That paper was for SHA-512, though its strategies are likely applicable to blake2b (and the block size is the same for both).

@rkeene rkeene added this to the V17.0 milestone Nov 9, 2018

@rkeene rkeene added the enhancement label Nov 9, 2018

@rkeene rkeene requested review from rkeene and clemahieu Nov 9, 2018

@PlasmaPower PlasmaPower force-pushed the PlasmaPower:r-gen-full-block branch from c99a597 to 70af14b Nov 9, 2018

rkeene added some commits Nov 9, 2018

@rkeene

rkeene approved these changes Nov 9, 2018

Copy link
Contributor

left a comment

Progress achieved !

@rkeene rkeene merged commit a2727af into nanocurrency:master Nov 9, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.